Chinese Remainder: Avoid map/zip/map courtesy of mamad :3

2021-02-08 18:55:40 +11:00
parent 15d9bb216a
commit fc8d16b6b8
1 changed files with 2 additions and 4 deletions
--- a/chinese_remainder/src/lib.rs
+++ b/chinese_remainder/src/lib.rs
@@ -46,11 +46,9 @@ pub fn chinese_remainder(residues: &[i64], moduli: &[i64]) -> Option<i64> {
    // TODO: Filter out 0s in moduli (meaning big_n is 0 -> div by 0)
    let big_n: i64 = moduli.iter().product();
    Some(moduli.iter()
-        .map(|&ni| {
-            egcd(ni, big_n / ni)
-        })
        .zip(residues)
-        .map(|(egcd,ai)| {
+        .map(|(&ni, ai)| {
+            let egcd = egcd(ni, big_n / ni);
            if egcd.gcd != 1 {
                // Fail in case moduli are not co-prime
                None